feat: adds a create combo key cli command for wallet #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeantonio21
changed the title
SWvheerden
reviewed
Sep 28, 2022
SWvheerden
reviewed
Sep 28, 2022
SWvheerden
reviewed
Sep 29, 2022
jorgeantonio21
requested review from
SWvheerden,
sdbondi and
hansieodendaal
SWvheerden
reviewed
Sep 30, 2022
sdbondi
reviewed
Sep 30, 2022
|
Nit: I fail to understand the use case here?
|
sdbondi
reviewed
Oct 3, 2022
sdbondi
reviewed
Oct 3, 2022
sdbondi
reviewed
Oct 3, 2022
sdbondi
approved these changes
Oct 3, 2022
stringhandler
pushed a commit
that referenced
this pull request
Oct 10, 2022
…key (#4759) Description --- The goal of the current PR is to add a cli command such that a wallet can create a utxo with a spend `CheckMultiSigVerifyAggregatePubKey` script that requires the a m-of-n list of keys to spend. It should be merged after #4742 and #4751. Motivation and Context --- It addresses `Step 2` in the following [MvP](https://demo.hedgedoc.org/rgLUGP_YRiGKjKkgehiG4w#Step-2). How Has This Been Tested? --- Unit tests
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 19, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 24, 2024
4 tasks
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 26, 2024
hansieodendaal
added a commit
to hansieodendaal/tari
that referenced
this pull request
Jun 27, 2024
SWvheerden
pushed a commit
that referenced
this pull request
Jun 28, 2024
Description --- Apply m_of_n_feature branch - PR #4751 - PRs #4759, #4776, #4798, #4822 Motivation and Context --- Add m-of-n scripting ability How Has This Been Tested? --- **Note:** Not tested yet What process can a PR reviewer use to test or verify this change? --- Code review <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
create_combo_keymethod to wallet. The main goal is to allow the user to create a new pair of (secret key, public key), by passing in a given string value.Motivation and Context
Wallet needs a terminal command to create a new public key and secret key from the key manager service.
This key needs to be created based on a provided string seed and send back to the user.
The key manager service derives a key based on the string and the master seed of the wallet. We need to add this seed string as a branch on the local instance of the key manager and then we can track if the user asks for the key twice.
The current command is needed in order to as a firs step to execute an m-of-n multi-party script payment protocol. See here and here for more details.
How Has This Been Tested?
Unit tests