feat: improve the TMS validation process #4694
Conversation
SWvheerden
changed the title
| ) | ||
| }) | ||
| .for_protocol(op_id)?; | ||
| .expect("Tx validation mined height is missing"); |
There was a problem hiding this comment.
I do not believe this is an improvement. In my mind the previous code that returned an error was better, but still not ideal.
I would prefer that we just log an error message and continue to the next last mined transaction should we have data inconsistencies. This way the protocol will not stop and do an endless repeat should we have a single row with problematic data.
There was a problem hiding this comment.
I removed this as the TMS defines a mined transaction as a tx with a mined_height and mined_block.
The above query we ask to get us a transaction with these properties explicitly asks the db for this.
See:
tari/base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
Lines 1069 to 1075 in 92ceef9
So the only reason this can be None is if somehow the memory got corrupted between asking the db and us now getting the value.
There was a problem hiding this comment.
this can't be an expect
| let mut _lock = validation_in_progress.try_lock().map_err(|_| { | ||
| debug!( | ||
| target: LOG_TARGET, | ||
| "Transaction Validation Protocol (Id: {}) spawned while a previous protocol was busy, ignored", id | ||
| ); | ||
| TransactionServiceProtocolError::new(id, TransactionServiceError::TransactionValidationInProgress) | ||
| })?; |
There was a problem hiding this comment.
I agree with this safeguard.
stringhandler
added
the
P-controversial
|
How does a user manually trigger a validation? |
Description
Adds a mutex on the TMS validation process to stop multiple validations running per time.
Motivation and Context
Validation on the transactions is run when the Base_node state changes, which is an automated event triggered when a base_node lags, a new block is received, or the wallet connects to a new base node. The other path for this is user triggered where the user manually triggers a validation.
Triggering more than one validation at a time is a waste of resources and network traffic as the wallet now asks the same basenode for the same data more than once.