fix: use dht inbound error for decryption (see issue #4596) #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Sep 1, 2022
sdbondi
previously approved these changes
Sep 1, 2022
|
I think let's merge after #4594 |
jorgeantonio21
changed the title
Yeah, this will conflict. Plus, there's a desire to provide more specific error types for decryption and padding failure modes in order to make tests cleaner. |
|
Mentioning issue #4596 so it links properly. |
… into ja_dht_inbound_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
DhtInboundErrorfor DHT message decryption.Motivation and Context
After an internal discussion, it was decided to output an error of
DhtInboundErrorinstead ofDhtOutboundError, incomms/dht/src/crypt.rs:131andcomms/dht/src/inbound/decryption.rs:409.Fixes #4596
How Has This Been Tested?
Run
cargo build