fix: grpc inconsistent serialization of keys (see issue #4224)

applications/tari_console_wallet/src/grpc/wallet_grpc_server.rs

@@ -198,9 +198,9 @@ impl wallet_server::Wallet for WalletGrpcServer {
     async fn identify(&self, _: Request<GetIdentityRequest>) -> Result<Response<GetIdentityResponse>, Status> {
         let identity = self.wallet.comms.node_identity();
         Ok(Response::new(GetIdentityResponse {
-            public_key: identity.public_key().to_string().into_bytes(),
+            public_key: identity.public_key().to_vec(),
             public_address: identity.public_address().to_string(),
-            node_id: identity.node_id().to_string().into_bytes(),
+            node_id: identity.node_id().to_vec(),
         }))
     }
 

integration_tests/features/support/ffi_steps.js

@@ -646,7 +646,7 @@ Then("I want to get public key of ffi wallet {word}", function (name) {
   let wallet = this.getWallet(name);
   let public_key = wallet.identify();
   expect(public_key.length).to.be.equal(
-    64,
+    32,
     `Public key has wrong length : ${public_key}`
   );
 });
@@ -723,7 +723,8 @@ Then(
       () => {
         let publicKeys = wallet.listConnectedPublicKeys();
         return (
-          publicKeys && publicKeys.some((p) => p === nodeIdentity.public_key)
+          publicKeys &&
+          publicKeys.some((p) => p === nodeIdentity.public_key.toString("hex"))
         );
       },
       true,

integration_tests/features/support/steps.js

@@ -508,7 +508,9 @@ When(
 
     await waitForPredicate(async () => {
       let peers = await firstNodeClient.listConnectedPeers();
-      return peers.some((p) => secondNodeIdentity.public_key === p.public_key);
+      return peers.some(
+        (p) => secondNodeIdentity.public_key.toString("hex") === p.public_key
+      );
     }, 50 * 1000);
   }
 );
@@ -519,7 +521,11 @@ Then(/(.*) is connected to (.*)/, async function (firstNode, secondNode) {
   const secondNodeIdentity = await secondNodeClient.identify();
   let peers = await firstNodeClient.listConnectedPeers();
   expect(
-    peers.some((p) => secondNodeIdentity.public_key === p.public_key)
+    peers.some(
+      (p) =>
+        secondNodeIdentity.public_key.toString("hex") ===
+        p.public_key.toString("hex")
+    )
   ).to.be.true;
 });