Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore test that timeout in github action #4010

Merged
merged 5 commits into from
Apr 7, 2022
Merged

fix: ignore test that timeout in github action #4010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9066c79
ignore tests that timesout in github action
mrnaveira Apr 7, 2022
c6d9cdb
need to change client pool expected values
mrnaveira Apr 7, 2022
4fb5157
Merge branch 'development' into ignore-timeout-test
mrnaveira Apr 7, 2022
90d27c0
implement PR suggestions
mrnaveira Apr 7, 2022
411481a
fix the timeout test
mrnaveira Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comms/core/src/connectivity/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ async fn pool_management() {
}

// Wait for all peers to be connected (i.e. for the connection manager events to be received)
let _result = collect_try_recv!(event_stream, take = 11, timeout = Duration::from_secs(10));
collect_try_recv!(event_stream, take = 11, timeout = Duration::from_secs(10));

let mut important_connection = connectivity
.get_connection(connections[0].peer_node_id().clone())
Expand Down
4 changes: 2 additions & 2 deletions comms/core/src/protocol/rpc/client/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ mod lazy_pool {
assert_eq!(pool.refresh_num_active_connections(), 1);
async_assert_eventually!(mock_state.num_open_substreams(), expect = 1);
let _rpc_client_lease = pool.get_least_used_or_connect().await.unwrap();
assert_eq!(pool.refresh_num_active_connections(), 1);
async_assert_eventually!(mock_state.num_open_substreams(), expect = 1);
assert_eq!(pool.refresh_num_active_connections(), 2);
async_assert_eventually!(mock_state.num_open_substreams(), expect = 2);
}

#[runtime::test]
Expand Down
2 changes: 1 addition & 1 deletion comms/core/src/protocol/rpc/test/smoke.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ async fn stream_still_works_after_cancel() {
.unwrap();

// Ask for a stream, but immediately throw away the receiver
let _client_streaming = client
client
.slow_stream(SlowStreamRequest {
num_items: 100,
item_size: 100,
Expand Down