chore: hide private values in debug and serialize #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
changed the title
Cifko
force-pushed
the
hide-private
branch
3 times, most recently
from
accc652 to
694fd51
Compare
sdbondi
reviewed
Mar 18, 2022
|
These ones are required to be serialized:
`base_layer\key_manager\src\wasm.rs
|
sdbondi
approved these changes
Mar 21, 2022
aviator-app bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
Description
---
- fixes regression where tor identity private key is not serialised in wallet db
Motivation and Context
---
Following error on wallet startup
```
ExitError { exit_code: WalletError, details: Some("Wallet storage error: `Error converting a type: `An error occurred de-/serialising an object from/into JSON``") }
```
Ref #3905
How Has This Been Tested?
---
Wallet starts up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
derivativemacro to get rid of the debug prints.Motivation and Context
Hide all private values that can be exposed accidentally via debug or serializing.
How Has This Been Tested?
integration tests only