Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test_faucet): include create_utxo to avoid unintentionally breaking faucet utxos #3771

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 28, 2022

Description

Include create utxo function directly in test_faucet code

Motivation and Context

test_helpers::create_utxo is a test function and could be modified for tests unintentionally breaking the faucet generation

How Has This Been Tested?

test_faucet works

@sdbondi sdbondi force-pushed the faucet-generator-create-utxo branch from 4acb0f3 to d1befc2 Compare January 28, 2022 12:32
@sdbondi sdbondi force-pushed the faucet-generator-create-utxo branch from d1befc2 to e1e1646 Compare January 28, 2022 12:33
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot merged commit cc2dd46 into tari-project:development Jan 31, 2022
@sdbondi sdbondi deleted the faucet-generator-create-utxo branch January 31, 2022 16:58
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 1, 2022
* development:
  chore: check genesis block during startup (tari-project#3776)
  chore: fix lint again (tari-project#3780)
  fix(core): fetch_header_containing_*_mmr functions now take a 0-based mmr position (tari-project#3749)
  refactor(test_faucet): include create_utxo to avoid unintentionally breaking faucet utxos (tari-project#3771)
  fix: text explorer show sha-3 correctly + minor fixes (tari-project#3779)
  feat: prevent ambiguous output features in transaction protocols (tari-project#3765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants