Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(collectibles): fix readme #3721

Merged
merged 2 commits into from
Jan 20, 2022
Merged

docs(collectibles): fix readme #3721

merged 2 commits into from
Jan 20, 2022

Conversation

stringhandler
Copy link
Collaborator

Fix readme instructions

hansieodendaal
hansieodendaal reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikethetike, thanks for the update.

Some comments.

applications/tari_collectibles/README.md
@@ -2,16 +2,15 @@

```bash
# run a tari_console_wallet with grpc on port 18143
# run a base node with grpc on port 18142
# run a validator node with grpc on port 18144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some more info:

  • The validator node section in tari_config_example.toml (imported from validator_node.toml) has information missing, for example the [validator_node] divider and I assume grpc_enabled and grpc_address.
  • General validator node command line options
  • It seems to clash with a running base node? - getting database locked error

applications/tari_collectibles/README.md

npm start # npm run tauri dev
#Then in root
cargo run --bin tari_collectibles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need normal runtime instructions, i.e. not via cargo.
So this executable has no config or other runtime dependencies not needed by the other tari applications?

@delta1 delta1 reopened this Jan 20, 2022
@aviator-app aviator-app bot merged commit 9054955 into tari-project:development Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal left review comments

@delta1 delta1 delta1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stringhandler @delta1 @hansieodendaal