test: improve cucumber scenario robustness #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved cucumber scenario robustness by explicitly waiting on the command mode to finish before proceeding with the next step for: - Scenario: Wallet imports spent outputs that become invalidated - Scenario: Wallet imports reorged outputs that become invalidated
philipr-za
reviewed
Nov 22, 2021
philipr-za
approved these changes
Nov 22, 2021
philipr-za
changed the title
hansieodendaal
changed the title
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 23, 2021
* development: fix: seed word parsing (tari-project#3607) feat: add ban peers metric (tari-project#3605) feat!: expose reason for transaction cancellation for callback in wallet_ffi (tari-project#3601) test: improve cucumber scenario robustness (tari-project#3599) feat: use CipherSeed wallet birthday for recovery start point (tari-project#3602) docs: ignore RFC code blocks (tari-project#3603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved cucumber scenario robustness by explicitly waiting on the command mode to finish before proceeding with the next step for:
Scenario: Wallet imports spent outputs that become invalidatedScenario: Wallet imports reorged outputs that become invalidatedMotivation and Context
The above-mentioned tests failed now and again, at least 1 in 10.
How Has This Been Tested?
Repeatedly running these tests 10 times on two different computers.
npm test -- --name "Wallet imports spent outputs that become invalidated"npm test -- --name "Wallet imports reorged outputs that become invalidated"