Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add wallet ffi to build and fix release build for wallet #3353

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,19 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: build
# args: --release
args: --release

- name: cargo build wallet
uses: actions-rs/cargo@v1
with:
command: build
args: -p tari_wallet
args: --release -p tari_wallet

- name: cargo build wallet ffi
uses: actions-rs/cargo@v1
with:
command: build
args: --release -p tari_wallet_ffi

test:
name: test
Expand Down
1 change: 1 addition & 0 deletions base_layer/core/src/transactions/aggregated_body.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ impl AggregateBody {

/// Create a new aggregate body from provided inputs, outputs and kernels.
/// It is up to the caller to ensure that the inputs, outputs and kernels are sorted
#[cfg(feature = "base_node")]
pub(crate) fn new_sorted_unchecked(
inputs: Vec<TransactionInput>,
outputs: Vec<TransactionOutput>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ impl<B: BlockchainBackend + 'static> BlockValidator<B> {

let block = Block::new(
valid_header,
// UNCHECKED: the validator has checked all inputs/outputs are sorted and preserves order in it's output
// UNCHECKED: the validator has checked all inputs/outputs are sorted and preserves order in its output
AggregateBody::new_sorted_unchecked(inputs_result.inputs, outputs_result.outputs, kernels_result.kernels),
);

Expand Down