ci: add wallet ffi to build #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
force-pushed
the
mb-add-wallet-ffi-to-ci
branch
from
829e5da to
a4a62b9
Compare
sdbondi
approved these changes
Sep 16, 2021
|
Looks good. We should also add the wallet ffi builds that compile libraries specific to the android and iOS devices to CI (the ones that run the mobile_build.sh script). This will show any compilation problems of the library specific to the device architectures. Just a note. |
delta1
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wallet FFI to build.
Previously this would fail on the cucumber step