Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rerun flaky tests #3335

Merged

Conversation

stringhandler
Copy link
Collaborator

Description

Try to run cucumber in parallel.
Also added flaky tests back with a retry option

Motivation and Context

Attempting to speed up cucumber test run

How Has This Been Tested?

sdbondi
sdbondi previously approved these changes Sep 13, 2021
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - seemed to take longer probably because it is retrying flakey tests.

@stringhandler stringhandler changed the title ci: run cucumber in parallel ci: rerun flaky tests Sep 15, 2021
aviator-app bot pushed a commit that referenced this pull request Sep 16, 2021
Description
---
Use `new_sorted_unchecked` function to keep clippy happy when base_node feature is not active
in tari_core.

Motivation and Context
---
Causing failed CI build (e.g. #3335 )

How Has This Been Tested?
---
CI must pass (FFI tests)
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though might hide an issue now and then but I guess if it is serious a retry won't fix it.

@aviator-app aviator-app bot merged commit c585a3f into tari-project:development Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants