revert: fix ban header syn peer if no headers provided (#3297) #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
changed the title
sdbondi
changed the title
sdbondi
changed the title
stringhandler
approved these changes
Sep 6, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
…3297) (tari-project#3306) Description --- This reverts commit 570e222. Motivation and Context --- tari-project#3297 (comment) Having thought about it a bit - header sync is designed to be self contained. It does not have the information required to ban a peer that "lied" in listening mode. Suggest that we pass through the chain metadata and peer that 'kicked' the base node into sync into header sync so that the peer can be banned if it fails to follow through. We should also not prevent mining when in header sync until a split and better chain have been comfirmed by header sync. How Has This Been Tested? --- Existing tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 570e222.
Motivation and Context
#3297 (comment)
Having thought about it a bit - header sync is designed to be self contained. It does not have the information required to ban a peer that "lied" in listening mode.
Suggest that we pass through the chain metadata and peer that 'kicked' the base node into sync into header sync so
that the peer can be banned if it fails to follow through. We should also not prevent mining when in header sync until a
split and better chain have been comfirmed by header sync.
How Has This Been Tested?
Existing tests pass