feat: add sync rpc client pool to wallet connectivity #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-connectivity-add-pool-for-sync
branch
4 times, most recently
from
2dac222 to
4cd68f2
Compare
- add sync pool and `obtain_base_node_sync_rpc_client` - add `get_header` to base node rpc
sdbondi
force-pushed
the
wallet-connectivity-add-pool-for-sync
branch
from
4cd68f2 to
d7e7be0
Compare
| self.base_node_wallet_rpc_client_pool = Some(pool); | ||
| self.pools = Some(ClientPoolContainer { | ||
| base_node_sync_rpc_client: conn.create_rpc_client_pool(self.config.base_node_rpc_pool_size), | ||
| base_node_wallet_rpc_client: conn.create_rpc_client_pool(self.config.base_node_rpc_pool_size), |
There was a problem hiding this comment.
The base_node_wallet_rpc_client should have its own pool size configuration setting and not reuse the one from base_node_sync_rpc_client. Both pool size values should be present in the config.toml configuration file for case by case tuning. A busy console wallet needs to carry out much more than base_node_rpc_pool_size: 10, conversations in parallel, specifically where the base_node_wallet_rpc_client is concerned, if it is going to be used for the transaction monitoring protocols.
| @@ -68,7 +69,7 @@ impl WalletConnectivityHandle { | |||
| /// node/nodes. It will be block until this is happens. The ONLY other time it will return is if the node is | |||
There was a problem hiding this comment.
Suggested change
| /// node/nodes. It will be block until this is happens. The ONLY other time it will return is if the node is | |
| /// node/nodes. It will be blocked until this is happening. The ONLY other time it will return is if the node is |
| /// Obtain a BaseNodeSyncRpcClient. | ||
| /// | ||
| /// This can be relied on to obtain a pooled BaseNodeSyncRpcClient rpc session from a currently selected base | ||
| /// node/nodes. It will be block until this is happens. The ONLY other time it will return is if the node is |
There was a problem hiding this comment.
Suggested change
| /// node/nodes. It will be block until this is happens. The ONLY other time it will return is if the node is | |
| /// node/nodes. It will be blocked until this is happening. The ONLY other time it will return is if the node is |
| /// node/nodes. It will be block until this is happens. The ONLY other time it will return is if the node is | ||
| /// shutting down, where it will return None. Use this function whenever no work can be done without a | ||
| /// BaseNodeSyncRpcClient RPC session. | ||
| pub async fn obtain_base_node_sync_rpc_client(&mut self) -> Option<RpcClientLease<BaseNodeSyncRpcClient>> { |
There was a problem hiding this comment.
Where will this be used in the wallet? Is it for get_chain_metadata?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
obtain_base_node_sync_rpc_clientget_headerto base node rpcMotivation and Context
Useful in #3191
How Has This Been Tested?
Existing unit tests
Checklist:
developmentbranch.