Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug that causes non p2p apps to panic on startup #3131

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jul 22, 2021

Description

Exclude non p2p apps from needing comms configuration

Motivation and Context

Bug fix

How Has This Been Tested?

Merge mining proxy and standalone miner starts successfully

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

Exclude non p2p apps from needing comms configuration
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's hope we can remove this in the near future

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 23, 2021

PR queued successfully. Your position in queue is: 3

@aviator-app
Copy link
Contributor

aviator-app bot commented Jul 23, 2021

PR is on top of the queue now

@aviator-app aviator-app bot merged commit 389dd74 into tari-project:development Jul 23, 2021
@sdbondi sdbondi deleted the config-fixes branch July 25, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants