Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected error with wallet power updates #1994

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

philipr-za
Copy link
Contributor

Description

If the power state is updated in the wallet before any Transaction activity occurs there are no subscribers to the broadcast channel which produced an incorrect error.

This PR logs the event but does not send it back across the FFI as an error.

How Has This Been Tested?

Test updated to test this case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

If the power state is updated in the wallet before any Transaction activity occurs there are no subscribers to the broadcast channel which produced an incorrect error.

This PR logs the event but does not send it back across the FFI as an error.
@philipr-za philipr-za requested a review from StriderDM June 15, 2020 08:10
Copy link
Contributor

@StriderDM StriderDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukabi
Copy link
Contributor

kukabi commented Jun 15, 2020

Thanks 🎉

@CjS77 CjS77 merged commit dfef9d5 into development Jun 15, 2020
@CjS77 CjS77 deleted the philip-fix-low-power-issue branch June 24, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants