Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flaky base node tests #1947

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fix for flaky base node tests #1947

merged 1 commit into from
Jun 4, 2020

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jun 3, 2020

Description

Base node and mempool integration tests construct their test networks using the most
optimal ordering. This reduces/removes test flakiness.

The databases files for nodes are no longer shared as this would cause
tests to sporadically fail on MacOS.

Motivation and Context

Improve test reliability

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Base node and mempool integration tests construct their test networks using the most
optimal ordering. This reduces/removes test flakiness.

The databases files for nodes are no longer shared as this would cause
tests to sporadically fail on MacOS.
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdbondi sdbondi merged commit 139117a into development Jun 4, 2020
@CjS77 CjS77 deleted the sb-bn-flaky-tests branch June 9, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants