Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framed substream default maximum frame size #1940

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

hansieodendaal
Copy link
Contributor

Description

Added a maximum frame length constant for a framed substream, equal to the default Tokio setting, so it can be visible in the Tari code and not dependent on the default frame size.

Motivation and Context

Difficult to find this default setting for tuning when it is hidden away in the Tokio libraries. This will also protect the Tari code base from future Tokio code changes.

How Has This Been Tested?

Tested in a base node exe.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits - but otherwise looks good

comms/src/protocol/messaging/protocol.rs Outdated Show resolved Hide resolved
comms/src/protocol/messaging/protocol.rs Outdated Show resolved Hide resolved
…an be visible in the Tari code and not dependent on the default frame size.
@hansieodendaal hansieodendaal force-pushed the ho_frame_size_for_substream branch from da6b8d4 to ca06766 Compare June 2, 2020 18:49
@sdbondi sdbondi merged commit 5bdc267 into development Jun 3, 2020
@sdbondi sdbondi deleted the ho_frame_size_for_substream branch June 3, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants