Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit cargo:rerun-if-changed directives automatically for protobuf builds #1926

Merged
merged 1 commit into from
May 29, 2020

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented May 29, 2020

Description

Add a builder option to enable emitting rerun-if-changed cargo build
directives for all proto files. This removes the need to manually maintain
a list or proto files in build.rs.

Also fixed compile issues for wallet FFI libs

@sdbondi sdbondi changed the title Emit cargo:rerun-if-changed directives automatically for protobuf Emit cargo:rerun-if-changed directives automatically for protobuf builds May 29, 2020
@sdbondi sdbondi force-pushed the sb-proto-build-directives branch from c5b5bd0 to 93d17d3 Compare May 29, 2020 09:25
Add a builder option to enable emitting `rerun-if-changed` cargo build
directives for all proto files. This removes the need to manually maintain
a list or proto files in build.rs.
@sdbondi sdbondi force-pushed the sb-proto-build-directives branch from 93d17d3 to 60da27b Compare May 29, 2020 12:32
@StriderDM StriderDM self-requested a review May 29, 2020 12:53
Copy link
Contributor

@StriderDM StriderDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdbondi, mobile builds are working again.

@sdbondi sdbondi merged commit ce1b404 into development May 29, 2020
@philipr-za philipr-za deleted the sb-proto-build-directives branch June 2, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants