Switched the BlockEvent stream to Tokio broadcast #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
requested changes
May 20, 2020
base_layer/core/src/base_node/comms_interface/local_interface.rs
Outdated
Show resolved
Hide resolved
…nts as it keeps the full set of events up to the specified bound limit even when the receivers have already processed the events. Using a tokio broadcast channel will result in less memory usage as all fully received events will be discarded without reaching the bound limit. - The BlockEvent stream currently uses the tari_broadcast_channel, this channel is bounded and does not clear when the receivers have read the events. As newly added and reorged blocks are distributed between services using this event stream, the channel can be memory intensive. - These changes replaced the tari_broadcast_channel used for the BlockEvent stream with a tokio broadcast channel. The Tokio broadcast channel has the benefit of removing the events from the channel as soon as all the receivers have read the events. This should minimise the amount of memory required.
neonknight64
force-pushed
the
yuko-block_event_broadcast_channel
branch
from
d5f2a2d to
b4d571a
Compare
sdbondi
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The tari_broadcast_channel is memory intensive for sharing BlockEvents as it keeps the full set of events up to the specified bound limit even when the receivers have already processed the events. Using a tokio broadcast channel will result in less memory usage as all fully received events will be discarded without reaching the bound limit.
How Has This Been Tested?
Covered by existing tests.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.