Add msg tag to the DHT header to enable traces across nodes.

[hansieodendaal]

Description

Enabling tracking of messages across nodes during testnet.

Example trace across nodes:
Sender stage 1

2020-05-20 10:51:38.181692300 [wallet::transaction_service::protocols::send_protocol] DEBUG Transaction (TxId: 17864096577764166221) Direct Send to 34ff4b3d9b20b76237becba4a839616a0b12441bb7a02152efdb08276e60e21e queued with Message Tag: MessageTag(9987700374622772089)
Header: Network: TestNet, Flags: NONE, Destination: Unknown, Trace: Tag#9987700374622772089
Tag#9987700374622772089
2020-05-20 10:51:38.181692300 [comms::dht::serialize] DEBUG Serializing outbound message MessageTag(9987700374622772089)
2020-05-20 10:51:45.683754200 [comms::protocol::messaging::outbound] TRACE Sending message (161 bytes) (MessageTag(9987700374622772089)) on outbound messaging substream
2020-05-20 10:51:45.684755600 [comms::protocol::messaging] TRACE Internal messaging event 'MessageSent(Tag#9987700374622772089)'

Receiver stage 1

2020-05-20 10:51:46.201902100 [comms::dht::deserialize] DEBUG Deserialization succeeded. Passing message Tag#8017475515622449727 onto next service (Trace: Tag#9987700374622772089)
Header: DhtMessageHeader (Dest:Unknown, Type:None, Network:TestNet, Flags:NONE, Trace:Tag#9987700374622772089)
2020-05-20 10:51:46.255901200 [wallet::transaction_service::service] TRACE Handling Transaction Message, Trace: Tag#9987700374622772089
2020-05-20 10:51:46.255901200 [wallet::transaction_service::service] TRACE Transaction (TxId: 17864096577764166221) received from 2609540b35ae89562ac985a7d5ba38e94ada5fd9dea3aa9781dd3c75eeb0cd5a, Trace: Tag#9987700374622772089
BUG Transaction Reply (TxId: 17864096577764166221) Direct Send to 2609540b35ae89562ac985a7d5ba38e94ada5fd9dea3aa9781dd3c75eeb0cd5a queued with Message Tag: MessageTag(9469085710403154976), Trace: Tag#9987700374622772089
2020-05-20 10:51:46.297899400 [wallet::transaction_service::service] INFO  Direct Send of Transaction Reply message for TX_ID: 17864096577764166221 was successful, Trace: Tag#9987700374622772089
2020-05-20 10:51:46.304898100 [wallet::transaction_service::service] INFO  Transaction with TX_ID = 17864096577764166221 received from 2609540b35ae89562ac985a7d5ba38e94ada5fd9dea3aa9781dd3c75eeb0cd5a, Trace: Tag#9987700374622772089. Reply Sent
2020-05-20 10:51:46.304898100 [wallet::transaction_service::service] INFO  Transaction (TX_ID: 17864096577764166221) - Amount: 9000 µT - Message: #Test direct Tx send 20200520_1050, Trace: Tag#9987700374622772089

Receiver stage 2

Header: Network: TestNet, Flags: NONE, Destination: Unknown, Trace: Tag#9469085710403154976
Tag#9469085710403154976
2020-05-20 10:51:46.296898000 [comms::dht::serialize] DEBUG Serializing outbound message MessageTag(9469085710403154976)
2020-05-20 10:51:46.297899400 [wallet::transaction_service::service] DEBUG Transaction Reply (TxId: 17864096577764166221) Direct Send to 2609540b35ae89562ac985a7d5ba38e94ada5fd9dea3aa9781dd3c75eeb0cd5a queued with Message Tag: MessageTag(9469085710403154976), Trace: Tag#9987700374622772089
2020-05-20 10:51:46.297899400 [comms::protocol::messaging::outbound] TRACE Sending message (869 bytes) (MessageTag5710403154976)) on outbound messaging substream
2020-05-20 10:51:46.297899400 [comms::protocol::messaging] TRACE Internal messaging event 'MessageSent(Tag#9469085710403154976)'

Sender stage 2

2020-05-20 10:51:46.804956900 [comms::dht::deserialize] DEBUG Deserialization succeeded. Passing message Tag#14698651695090578213 onto next service (Trace: Tag#9469085710403154976)
Header: DhtMessageHeader (Dest:Unknown, Type:None, Network:TestNet, Flags:NONE, Trace:Tag#9469085710403154976)
2020-05-20 10:51:46.805956400 [wallet::transaction_service::service] TRACE Handling Transaction Reply Message, Trace: Tag#9469085710403154976

Motivation and Context

Sometimes messages disappear between nodes; this change to enable tracking messages across nodes during testnet by inserting the originating message tag into the DHT header.

How Has This Been Tested?

Tested between 2x Windows and 1x Linux nodes.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
• New Tests
• Documentation

Checklist:

• I'm merging against the development branch.
• I ran cargo-fmt --all before pushing.
• I have squashed my commits into a single commit.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[philipr-za]

Main comment is that I think you should be consistent and change Message Trace to MessageTag both in the type and the log labels to make it clear what it is and to conform to how it is used and referred to in the rest of the code.

[philipr-za]

LGTM