UI feedback of state machine #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_add_state_UI_feedback
branch
2 times, most recently
from
a56db65 to
d5b84a0
Compare
sdbondi
reviewed
May 20, 2020
| self.executor.spawn(async move { | ||
| match channel.next().await { | ||
| None => { | ||
| println!("Something went wrong"); |
There was a problem hiding this comment.
None happens when the channel closes (e.g. if the node shuts down). I wouldn't print any output in this case as it might give the user an impression of instability. The log below could be an info! saying that the state machine state channel closed.
| @@ -64,6 +64,7 @@ impl ListeningData { | |||
| pub async fn next_event<B: BlockchainBackend>(&mut self, shared: &mut BaseNodeStateMachine<B>) -> StateEvent { | |||
| info!(target: LOG_TARGET, "Listening for chain metadata updates"); | |||
| shared.info = StatusInfo::Listening(ListeningInfo::new()); | |||
| let _ = shared.status_event_publisher.send(shared.info.clone()).await; | |||
There was a problem hiding this comment.
Ideally, publishing an event would just be wrapped in a function
Suggested change
| let _ = shared.status_event_publisher.send(shared.info.clone()).await; | |
| shared.publish_status_event(shared.info.clone()).await; |
| @@ -161,6 +161,7 @@ impl BlockSyncStrategy { | |||
| ) -> StateEvent | |||
| { | |||
| shared.info = StatusInfo::BlockSync(BlockSyncInfo::new(None, None, None)); | |||
| let _ = shared.status_event_publisher.send(shared.info.clone()).await; | |||
There was a problem hiding this comment.
Write and use a publish_status_event function
SWvheerden
force-pushed
the
sw_add_state_UI_feedback
branch
from
a610e52 to
90c1c18
Compare
sdbondi
previously approved these changes
May 20, 2020
SWvheerden
force-pushed
the
sw_add_state_UI_feedback
branch
from
90c1c18 to
8b775e8
Compare
sdbondi
approved these changes
May 20, 2020
sdbondi
previously approved these changes
May 20, 2020
sdbondi
reviewed
May 20, 2020
SWvheerden
force-pushed
the
sw_add_state_UI_feedback
branch
from
8b775e8 to
8147ea1
Compare
…edback Changed listing state display to be more clear Co-authored-by: Stan Bondi <[email protected]> Add comment to describe why the channel will never be empty
SWvheerden
force-pushed
the
sw_add_state_UI_feedback
branch
from
8147ea1 to
a6a9cd6
Compare
sdbondi
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a channel to the base_node parser to listen for state machine publisher to publish its state and info.
Motivation and Context
This PR provides feedback for the user to see what the status and info from the state machine is, like how syncing is, is it syncing etc.
How Has This Been Tested?
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.