Add check for duplicate transactional inputs and outputs in validators #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,12 +114,18 @@ impl<B: BlockchainBackend> Validation<Block, B> for FullConsensusValidator { | |||
| trace!(target: LOG_TARGET, "FCV - Coinbase output ok for {}", &block_id); | |||
| check_block_weight(block, &self.rules.consensus_constants())?; | |||
| trace!(target: LOG_TARGET, "FCV - Block weight ok for {}", &block_id); | |||
| check_duplicate_transactions_inputs(block)?; | |||
There was a problem hiding this comment.
Can you add the description of the check to the validate function doc string list.
SWvheerden
force-pushed
the
sw_addduplicate_validation_check
branch
from
b951f43 to
261070d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check for duplicate inputs and outputs in blocks for the validators
Motivation and Context
There is not check other than the database settings to ensure that inputs and outputs are not duplicate. This means a block can pass validation although its not valid.
How Has This Been Tested?
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.