Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Store and forward] Private message storage and retrieval #1697

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Apr 14, 2020

Description

Storage and retreival of messages without an origin (PR #1686)
All private/anonymous messages are stored as low priority (short TTL)
messages.

  • New response type Anonymous for store and forward query responses
  • Added some more logging
  • DHT store and forward integration test
  • SAF messages can never be stored in store and forward

Motivation and Context

Since messages can be completely private (no known source or destination) SAF needs to store and relay these messages.

How Has This Been Tested?

Added a store and forward integration test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sdbondi sdbondi force-pushed the sb-dht-saf-anon-msgs branch 3 times, most recently from 79a74a1 to 719732b Compare April 14, 2020 12:34
Storage and retreival of messages without an origin (PR #1686)
All private/anonymous messages are stored as low priority (short TTL)
messages.

- New response type `Anonymous` for store and forward query responses
- Added some more logging
- DHT store and forward integration test
- SAF messages can never be stored in store and forward
@sdbondi sdbondi force-pushed the sb-dht-saf-anon-msgs branch from 719732b to 71974b5 Compare April 14, 2020 12:36
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 merged commit 6d27e5d into development Apr 14, 2020
@CjS77 CjS77 deleted the sb-dht-saf-anon-msgs branch April 14, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants