Removed redundant messaging authentication #1691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comms-level (direct peer-to-peer) message authentication is a hangover
from the zMQ comms control port and can be removed.
Direct wire messages are authenticated by the noise protocol.
Comms-level messaging protocol simply sends blobs between peers similar to zMQ-style messaging
Motivation and Context
This reduces the number of bytes sent over the wire. Removes (de)serialization of envelopes and signature creation/verification on outbound/inbound messaging
Note this is a breaking network change. Getting all the breaking changes out of the way along with #1686
How Has This Been Tested?
Existing tests updated/removed (less code to test)
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.