Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant messaging authentication #1691

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Apr 11, 2020

Description

Comms-level (direct peer-to-peer) message authentication is a hangover
from the zMQ comms control port and can be removed.
Direct wire messages are authenticated by the noise protocol.
Comms-level messaging protocol simply sends blobs between peers similar to zMQ-style messaging

Motivation and Context

This reduces the number of bytes sent over the wire. Removes (de)serialization of envelopes and signature creation/verification on outbound/inbound messaging

Note this is a breaking network change. Getting all the breaking changes out of the way along with #1686

How Has This Been Tested?

Existing tests updated/removed (less code to test)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Comms-level (direct peer-to-peer) message authentication is a hangover
from the zMQ comms control port and can be removed.
Direct wire messages are authenticated by the noise protocol.

Note this is a breaking network change.
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 merged commit f085da9 into development Apr 14, 2020
Copy link
Contributor

@neonknight64 neonknight64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 deleted the sb-comms-remove-comms-envelope branch April 14, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants