Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMR use position as u32 #5924

Closed
SWvheerden opened this issue Nov 8, 2023 · 1 comment · Fixed by #5956
Closed

MMR use position as u32 #5924

SWvheerden opened this issue Nov 8, 2023 · 1 comment · Fixed by #5956

Comments

@SWvheerden
Copy link
Collaborator

The mmrs use the position as a u32, this should be u64.
@AaronFeickert
Copy link
Collaborator

Do you mean internally to the MMR design, or in callers (like the synchronizer)?

@AaronFeickert AaronFeickert mentioned this issue Nov 14, 2023
Merged
SWvheerden pushed a commit that referenced this issue Nov 16, 2023
@AaronFeickert
feat!: move kernel MMR position to u64 (#5956)
cdd8a31 
Description
---
Switches the handling of kernel MMR positions from `u32` to `u64`.

Closes #5924.

Motivation and Context
---
Internally, MMR positions are handled as either `usize` or `u64`.
However, they are eventually parsed and handled as `u32` for storage.
While it doesn't address the internal `usize` handling, it switches
storage operations to be `u64`.

How Has This Been Tested?
---
Existing tests pass.

What process can a PR reviewer use to test or verify this change?
---
Assert that the logic, especially around LMDB operations, is correct.

BREAKING CHANGE: Modifies the handling of kernel MMR data in LMDB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: move kernel MMR position to u64 AaronFeickert/tari
2 participants
@SWvheerden @AaronFeickert