Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync is always done with a single peer #5852

Closed
SWvheerden opened this issue Oct 23, 2023 · 0 comments · Fixed by #5890
Closed

Sync is always done with a single peer #5852

SWvheerden opened this issue Oct 23, 2023 · 0 comments · Fixed by #5890
Assignees
@SWvheerden
Labels
release-blocker Something that needs to be fixed before a release can be made

Comments

@SWvheerden
Copy link
Collaborator

Sync is always done with a single peer.

While this is fine for syncing intermittently where your node is already in sync, it gets a notification from one of its closest connected peers that it's behind, it should sync to that peer.

On start up this is different, the node should wait a bit and make a bit more informed decision on what peer to sync from and perhaps select a list.
@SWvheerden SWvheerden added the release-blocker Something that needs to be fixed before a release can be made label Oct 23, 2023
@SWvheerden SWvheerden self-assigned this Oct 31, 2023
@SWvheerden SWvheerden mentioned this issue Oct 31, 2023
Merged
SWvheerden added a commit that referenced this issue Nov 1, 2023
@SWvheerden
feat: allow multiple initial sync peers (#5890)
e1c504a 
Description
---
Allow syncing from multiple peers initially

Motivation and Context
---
See issue: #5852 
This allows a node to wait until it gets 5 ChainMetaData during initial
sync until it goes to header sync.

How Has This Been Tested?
---
Unit tests


Fixes: #5852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
release-blocker Something that needs to be fixed before a release can be made
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow multiple initial sync peers SWvheerden/tari
1 participant
@SWvheerden