Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet shows rejected tx, but balance still reflects transaction #5227

Closed
SWvheerden opened this issue Mar 7, 2023 · 2 comments
Closed

wallet shows rejected tx, but balance still reflects transaction #5227

SWvheerden opened this issue Mar 7, 2023 · 2 comments
Assignees
@agubarev
Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.

Comments

@SWvheerden
Copy link
Collaborator

SWvheerden commented Mar 7, 2023 •
edited
Loading

The detail tx view shows the transaction as rejected. But the balance still shows the available balance as including that transaction
Screenshot 2023-03-07 at 19 17 12
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. A-wallet Area - related to the wallet labels Mar 7, 2023
@SWvheerden
Copy link
Collaborator Author

wallet.zip

@SWvheerden
Copy link
Collaborator Author

wallet_log.zip

@SWvheerden SWvheerden moved this to Backlog in Tari Esme Testnet Mar 13, 2023
@SWvheerden SWvheerden moved this from Backlog to Must Do in Tari Esme Testnet Mar 14, 2023
@agubarev agubarev self-assigned this Mar 14, 2023
@SWvheerden SWvheerden moved this from Must Do to Selected for development in Tari Esme Testnet Mar 14, 2023
@agubarev agubarev moved this from Selected for development to In Progress in Tari Esme Testnet Mar 14, 2023
@agubarev agubarev mentioned this issue Mar 14, 2023
Merged
@agubarev agubarev moved this from In Progress to In Review in Tari Esme Testnet Mar 14, 2023
SWvheerden added a commit that referenced this issue Mar 15, 2023
@agubarev @SWvheerden
fix: added transaction revalidation to the wallet startup sequence #5227
7b4e2d2 
 (#5246)

Description
---
Now wallet revalidates all transactions included in the wallet on
startup.

#5227

Motivation and Context
---
Outputs fetched from a fully synced node could be invalidated by the
transaction validator, e.g. wallet has normal outputs,
fully validated, but at some point become invalidated when the wallet is
trying to negotiate with another, not yet fully synced node that doesn't
recognise said output due to not reaching its height at the moment.

So, the code was already there but not yet used in the startup process.

How Has This Been Tested?
---
manually

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

Co-authored-by: SW van Heerden <[email protected]>
@SWvheerden SWvheerden mentioned this issue Mar 15, 2023
Merged
stringhandler pushed a commit that referenced this issue Mar 15, 2023
@SWvheerden
chore(release): v0.49.0-pre.1 (#5248)
57781b6 
### ⚠ BREAKING CHANGES

* **wallet:** ensure burn shared keys and hashes match dan layer (5245)
* add claim public key to OutputFeatures (5239)
* reset esmeralda (5247)

### Features

* add claim public key to OutputFeatures
([5239](#5239))
([3e7d82c](3e7d82c))
* reset esmeralda
([5247](#5247))
([aa2a3ad](aa2a3ad))


### Bug Fixes

* added transaction revalidation to the wallet startup sequence
[5227](#5227)
([5246](#5246))
([7b4e2d2](7b4e2d2))
* immediately fail to compile on 32-bit systems
([5237](#5237))
([76aeed7](76aeed7))
* **wallet:** correct change checks in transaction builder
([5235](#5235))
([768a0cf](768a0cf))
* **wallet:** ensure burn shared keys and hashes match dan layer
([5245](#5245))
([024ce64](024ce64))
* windows path format in log4rs files
([5234](#5234))
([acfecfb](acfecfb))
@github-project-automation github-project-automation bot moved this from In Review to Done in Tari Esme Testnet Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubarev agubarev

Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agubarev @SWvheerden