fix(wallet-grpc): return correct available balance and add timelocked balance #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Feb 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_balance call to returns timelocked_balance
get_balance call returns funds that are immediately spendable
Motivation and Context
Calls to get_balance seemingly do not yield the correct balance, e.g your wallet ui says available balance == 0 but the grpc call says available_balance > 0 (because it includes the timelocked funds). This PR changes the available_balance to reflect the amount of funds immediately spendable. This only happens on the grpc level to avoid a breaking change in other code (FFI etc)
How Has This Been Tested?
Existing cucumber. Tested with VN that queries the balance.
BREAKING CHANGE: get_balance grpc call has changed, available_balance no longer includes timelocked funds only immediately available funds. This probably only is used currently in cucumber tests.