fix: dont dial local shards if epoch manager has not synced #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Feb 15, 2023
|
Will keep this as draft until tari-project/tari#5183 is merged |
sdbondi
force-pushed
the
fix-epoch-manager-failure
branch
from
b3d0163 to
3a953e8
Compare
* development: fix: dont initially register automatically (tari-project#372)
stringhandler
approved these changes
Feb 15, 2023
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 15, 2023
* development: fix: dont dial local shards if epoch manager has not synced (tari-project#370) fix: allow web UI to use OS-assigned JRPC address (tari-project#371) fix: dont initially register automatically (tari-project#372) fix: dont dial local shards if epoch manager has not synced (tari-project#369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
no auto-register when wallet has insufficient funds
Use correct consensus constants when checking for reregistration
Motivation and Context
Validator node will error when no funds are available. This PR checks the wallet balance before attempting to submit a transaction.
Depends on: tari-project/tari#5181 and tari-project/tari#5183
How Has This Been Tested?
Manually on fresh VN, cucumber tests also test this