fix: panic on overflow in release mode #5150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a toml config to do the same overflow/underflow check in debug mode in release mode.
Motivation and Context
By default, Rust will wrap an integer in release mode instead of throwing the overflow error seen in debug mode. Panicking at this time is better than silently using the wrong value. IMO this could lead to all sorts of exploits.
Some Tari specific background:
In the MMR crate there is this check:
We found in testing that on some machines this would panic and others would pass. (I can't remember if it was this exact line, since this should fail with allocating that much memory)
How Has This Been Tested?
Checked on rust pen to confirm that rust underflows in release mode with this code