Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base node banned other base node for providing the claimed difficulty #5143

Closed
SWvheerden opened this issue Jan 27, 2023 · 0 comments · Fixed by #5146
Closed

Base node banned other base node for providing the claimed difficulty #5143

SWvheerden opened this issue Jan 27, 2023 · 0 comments · Fixed by #5146
Assignees
@SWvheerden
Labels
A-base_node Area - The Tari base node executable and libraries C-bug Category - fixes a bug, typically associated with an issue.

Comments

@SWvheerden
Copy link
Collaborator

image
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. A-base_node Area - The Tari base node executable and libraries labels Jan 27, 2023
@SWvheerden SWvheerden self-assigned this Jan 27, 2023
@SWvheerden SWvheerden mentioned this issue Jan 27, 2023
Merged
stringhandler pushed a commit that referenced this issue Jan 31, 2023
@SWvheerden
fix: potential ban (#5146)
9892da6 
Description
---
Fixes potential ban by making a check before we ban. 

Motivation and Context
---
Under very rare circumstances it might be possible for the base_node to receive the blocks required to up its local metadata. 
And here we can ban a local peer for providing inaccurate chain metadata although he could have provided the correct number, our chain could have advanced enough to not switch over.  


Fixes: #5143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
A-base_node Area - The Tari base node executable and libraries C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: potential ban SWvheerden/tari
1 participant
@SWvheerden