feat: increase wallet FFI error codes #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
SW_fix_wallet_211_error
branch
from
896b61a to
3b9868e
Compare
SWvheerden
changed the title
CjS77
added
P-acks_required
stringhandler
approved these changes
Jan 18, 2023
CjS77
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a wallet function is called after
wallet_createand beforewallet_add_base_node_peerthe wallet will error with211. This increases the error codes to correctly error on 212NoBaseNodeKeysProvidedMotivation and Context
Fixes: #5116
Increases error clarity to help callee know whats wrong.
How Has This Been Tested?
manual