Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet FFI crashes with error 211 #5116

Closed
SWvheerden opened this issue Jan 16, 2023 · 0 comments · Fixed by #5118
Closed

Wallet FFI crashes with error 211 #5116

SWvheerden opened this issue Jan 16, 2023 · 0 comments · Fixed by #5118
Labels
A-wallet-ffi Area - Related to the wallet FFI lib C-bug Category - fixes a bug, typically associated with an issue.

Comments

@SWvheerden
Copy link
Collaborator

When a wallet is created on the FFI and straight away after creation we call wallet_import_external_utxo_as_non_rewindable the FFI crashes with error 211.

If we add a delay between the two, it works.

The suspicion is that the wallet has not finished creating the TMS before we try to use it.
@SWvheerden SWvheerden added C-bug Category - fixes a bug, typically associated with an issue. A-wallet-ffi Area - Related to the wallet FFI lib labels Jan 16, 2023
@SWvheerden SWvheerden mentioned this issue Jan 16, 2023
Merged
stringhandler pushed a commit that referenced this issue Jan 18, 2023
@SWvheerden
feat: increase wallet FFI error codes (#5118)
d5db596 
Description
---
When a wallet function is called after `wallet_create` and before `wallet_add_base_node_peer` the wallet will error with `211`. This increases the error codes to correctly error on 212 `NoBaseNodeKeysProvided`

Motivation and Context
---
Fixes: #5116 
Increases error clarity to help callee know whats wrong.

How Has This Been Tested?
---
manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet-ffi Area - Related to the wallet FFI lib C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: increase wallet FFI error codes SWvheerden/tari
1 participant
@SWvheerden