Clean up conflicting base node configs #4909
Assignees
Labels
A-base_node
Area - The Tari base node executable and libraries
C-bug
Category - fixes a bug, typically associated with an issue.
Milestone
Comments
sdbondi
added
C-bug
Merged
stringhandler
pushed a commit
that referenced
this issue
Nov 23, 2022
Description --- Removed `max_randomx_vms` from `BaseNodeStateMachineConfig` and the config preset, now passing the initialized RandomXFactory in via the initializer, same for `bypass_range_proof_verification` but passing only the setting Motivation and Context --- #4909 There are a few duplicate config keys that exist in the base node config and the base node state machine config meaning settings and behaviour could mismatch. `base_node.max_randomx_vms` (this setting will not work) `base_node.bypass_range_proof_verification` (this setting will not work) `base_node.force_sync_peers` (this was fixed in #4647 but the fix is a bit hacky) https://github.com/tari-project/tari/blob/956b27954dda1f15f82bff0ba0ba0ee1f0880d2d/base_layer/core/src/base_node/state_machine_service/state_machine.rs#L52 https://github.com/tari-project/tari/blob/development/applications/tari_base_node/src/config.rs#L109 ref #4646 How Has This Been Tested? --- manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a few duplicate config keys that exist in the base node config and the base node state machine config
meaning settings and behaviour could mismatch.
base_node.max_randomx_vms(this setting will not work)base_node.bypass_range_proof_verification(this setting will not work)base_node.force_sync_peers(this was fixed in #4647 but the fix is a bit hacky)tari/base_layer/core/src/base_node/state_machine_service/state_machine.rs
Line 52 in 956b279
https://github.com/tari-project/tari/blob/development/applications/tari_base_node/src/config.rs#L109
ref #4646
The text was updated successfully, but these errors were encountered: