Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowed list of opcodes on consensus #4821

Closed
SWvheerden opened this issue Oct 19, 2022 · 0 comments · Fixed by #4836
Closed

Add allowed list of opcodes on consensus #4821

SWvheerden opened this issue Oct 19, 2022 · 0 comments · Fixed by #4836
Assignees
@SWvheerden

Comments

@SWvheerden
Copy link
Collaborator

We need to add a list of allowed opcodes on the consensus that's allowed per height. Similar to how output, input, etc versions are handled
@SWvheerden SWvheerden moved this to Must Do in Tari Esme Testnet Oct 19, 2022
@stringhandler stringhandler moved this from Must Do to In Progress in Tari Esme Testnet Oct 20, 2022
@SWvheerden SWvheerden mentioned this issue Oct 20, 2022
Merged
@SWvheerden SWvheerden moved this from In Progress to In Review in Tari Esme Testnet Oct 21, 2022
stringhandler pushed a commit that referenced this issue Oct 25, 2022
@SWvheerden
feat: add opcode versions (#4836)
c8abe99 
Description
---
This adds in an opcode versioning that is allowed.
Refactors the validation to ensure transaction versioning info is check by blocks as well. 

Motivation and Context
---
We might need to add in new opcodes as hard forks. This adds the opcode version as part of the consensus code so we can track allowed opcodes. 

How Has This Been Tested?
---
Unit tests

Fixes: #4821
Repository owner moved this from In Review to Done in Tari Esme Testnet Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add opcode versions SWvheerden/tari
1 participant
@SWvheerden