Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet selects not yet matured utxos #4811

Closed
SWvheerden opened this issue Oct 17, 2022 · 1 comment · Fixed by #4854
Closed

Wallet selects not yet matured utxos #4811

SWvheerden opened this issue Oct 17, 2022 · 1 comment · Fixed by #4854
Assignees
@agubarev
Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Milestone
Stagenet Freeze

Comments

@SWvheerden
Copy link
Collaborator

Under certain conditions the function select_utxos selects utxo's which it cannot spend yet due to the timelocks.
Since PR #4227, the wallet can under certain conditions (not default) select UTXOs that have not yet been matured.
The Wallet should ALWAYS look to only select utxos that have matured on script_lock_height and maturity
@agubarev agubarev self-assigned this Oct 25, 2022
@agubarev agubarev mentioned this issue Oct 25, 2022
Merged
@stringhandler stringhandler added C-bug Category - fixes a bug, typically associated with an issue. A-wallet Area - related to the wallet labels Oct 31, 2022
stringhandler pushed a commit that referenced this issue Nov 7, 2022
@agubarev
fix: added UtxoSelectionMode to enable unrestricted output listing […
9f9179a 
…issue #4811] (#4854)

Description
---
Added UtxoSelectionMode to enable output listing, unrestricted by `script_lock_height` or `maturity`, it has two modes at the moment: `Safe` and `ListingOnly`: 
- `Safe` is supposed to be used when payment is expected,
- `ListingOnly` is to have an option to view existing outputs e.g., to see received, but yet to be matured outputs.

And brushed up a little for easier readability.

Motivation and Context
---
Under certain conditions the function select_utxos selects utxo's which it cannot spend yet due to the timelocks.
Since PR #4227, the wallet can under certain conditions (not default) select UTXOs that have not yet been matured.
The Wallet should ALWAYS look to only select utxos that have matured on script_lock_height and maturity

#4811

How Has This Been Tested?
---
existing unit tests
@stringhandler stringhandler added this to the Stagenet Freeze milestone Nov 15, 2022
@stringhandler stringhandler moved this to Selected for development in Tari Esme Testnet Nov 15, 2022
@sdbondi
Copy link
Member

sdbondi commented Nov 21, 2022

Closed by #4854

@sdbondi sdbondi closed this as completed Nov 21, 2022
Repository owner moved this from Selected for development to Done in Tari Esme Testnet Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubarev agubarev

Labels
A-wallet Area - related to the wallet C-bug Category - fixes a bug, typically associated with an issue.
Projects
Tari Esme Testnet
Archived in project
Milestone
Stagenet Freeze
Development

Successfully merging a pull request may close this issue.

fix: added UtxoSelectionMode to enable unrestricted output listing [issue #4811] agubarev/tari
4 participants
@sdbondi @agubarev @SWvheerden @stringhandler