Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console wallet/mempool] Mined transactions being invalidated due to DuplicateKernelError, Validation failed due to already mined kernel #4721

Closed
hansieodendaal opened this issue Sep 22, 2022 · 1 comment
Closed

[console wallet/mempool] Mined transactions being invalidated due to DuplicateKernelError, Validation failed due to already mined kernel #4721

hansieodendaal opened this issue Sep 22, 2022 · 1 comment
Assignees
@Cifko

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Sep 22, 2022 •
edited
Loading

In some cases, a perfectly fine transaction that has been submitted to the mempool and being monitored by the wallet will be invalidated in the mempool whren it has been mined due to DuplicateKernelError, Validation failed due to already mined kernel, but then marked invalid in the wallet as well.

This behaviour surfaces during many coin splits.
@hansieodendaal hansieodendaal changed the title [console wallet] Mined transactions being invalidated due to DuplicateKernelError: Validation failed due to already mined kernel [console wallet] Mined transactions being invalidated due to DuplicateKernelError, Validation failed due to already mined kernel Sep 22, 2022
@hansieodendaal hansieodendaal changed the title [console wallet] Mined transactions being invalidated due to DuplicateKernelError, Validation failed due to already mined kernel [console wallet/mempool] Mined transactions being invalidated due to DuplicateKernelError, Validation failed due to already mined kernel Sep 23, 2022
@sdbondi sdbondi moved this from Bugs to Must Do in Tari Esme Testnet Sep 23, 2022
@sdbondi sdbondi moved this from Must Do to In Progress in Tari Esme Testnet Sep 23, 2022
@Cifko Cifko mentioned this issue Sep 26, 2022
Merged
@stringhandler
Copy link
Collaborator

I think the broadcast protocol should not see this as an error.

@Cifko Cifko moved this from In Progress to In Review in Tari Esme Testnet Sep 26, 2022
stringhandler pushed a commit that referenced this issue Sep 26, 2022
@Cifko
fix: mined tx being invalid (#4735)
24e396d 
Description
---
Fix mined transaction marked as invalid in the wallet.
#4721

How Has This Been Tested?
---
I wasn't able to reproduce the original bug. So only github actions tests.
Repository owner moved this from In Review to Done in Tari Esme Testnet Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cifko Cifko

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SWvheerden @stringhandler @Cifko @hansieodendaal