Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify burn output rewind/re-org #4662

Closed
SWvheerden opened this issue Sep 12, 2022 · 0 comments · Fixed by #4697
Closed

Verify burn output rewind/re-org #4662

SWvheerden opened this issue Sep 12, 2022 · 0 comments · Fixed by #4697
Assignees
@SWvheerden

Comments

@SWvheerden
Copy link
Collaborator

This error has been spotted a few times:

[c::bn::block_sync] [cc1ade71a24700ddefc86457dbb6e1446229641b0e1c56bce909bcd0f1a0f950,7acd212bf3c3b5a0428ebfec90] WARN  Block sync failed: Chain storage error: Key c7cf0900 in deleted_txo_mmr_position_to_height_index already exists

They way to solve this, is delete the block and resync.
We know this is not some kind of propagation/sync disconnect issue as this occurs with sync, but a resync from 0 works.

This might be caused by rewinds/reorgs, not resetting or clearing burned outputs. We need to confirm this
@SWvheerden SWvheerden moved this to Bugs in Tari Esme Testnet Sep 12, 2022
@stringhandler stringhandler moved this from Bugs to In Progress in Tari Esme Testnet Sep 13, 2022
@stringhandler stringhandler moved this from In Progress to Must Do in Tari Esme Testnet Sep 16, 2022
@stringhandler stringhandler moved this from Must Do to In Progress in Tari Esme Testnet Sep 19, 2022
@SWvheerden SWvheerden mentioned this issue Sep 19, 2022
Merged
Repository owner moved this from In Progress to Done in Tari Esme Testnet Sep 20, 2022
stringhandler pushed a commit that referenced this issue Sep 20, 2022
@SWvheerden
fix: burned reorg (#4697)
08773f4 
Description
---
Fixes rewind to height for burned outputs

Motivation and Context
---
When rewinding the blockchain, the rewind tries to delete the "unspent" utxo. But burned outputs never have spent utxos created for them. This causes rewinds to break. 


How Has This Been Tested?
---
Added a new cucumber test

Fixes: #4662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: burned reorg SWvheerden/tari
2 participants
@agubarev @SWvheerden