fix(wallet): detect base node change during txo_validation #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-base-node-change-interrupt
branch
3 times, most recently
from
37a75b2 to
3e9f236
Compare
stringhandler
previously approved these changes
Sep 5, 2022
|
That test looks like it broke in this pr |
sdbondi
force-pushed
the
wallet-base-node-change-interrupt
branch
from
cc7e589 to
12a88cb
Compare
|
Looks like there are some problems here that need to be figured out - #4599 needs more info because it's unclear if the symptom noted in the issue is because the txo validation has begun before the base node is switched or after |
sdbondi
force-pushed
the
wallet-base-node-change-interrupt
branch
from
dc2bee8 to
047e846
Compare
|
The base node watch is a little tricky because there is no way to say "I've seen the value" without awaiting on |
sdbondi
force-pushed
the
wallet-base-node-change-interrupt
branch
from
047e846 to
5c1aba9
Compare
sdbondi
force-pushed
the
wallet-base-node-change-interrupt
branch
from
5c1aba9 to
ecaebc0
Compare
stringhandler
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interrupt txo_validation_protocol and txo_validation_task if base node is changed
Motivation and Context
These long-running tasks continue to run using the same base node even if it has changed. This PR checks for base node changes and interrupts the tasks at the correct points.
Other tasks may also need to be interrupted in a similar way.
Ref #4599 - this may fix this issue, but more info is needed to confirm
How Has This Been Tested?
Manually, changing the base node and checking that the tasks end.