Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet does not use "connected" base node #4599

Closed
SWvheerden opened this issue Sep 1, 2022 · 2 comments
Closed

Wallet does not use "connected" base node #4599

SWvheerden opened this issue Sep 1, 2022 · 2 comments

Comments

@SWvheerden
Copy link
Collaborator

There exist cases where the wallet is connected to a specific user set base_node, and shows its connected.
But when utxo validation process starts, it uses an rpc connection to a seed node defined in the config.

This should not happen. When a wallet is connected to a node, it should only use connections to that specific node.
@SWvheerden SWvheerden moved this to Todo in Tari Esme Testnet Sep 1, 2022
@sdbondi sdbondi moved this from Todo to In Progress in Tari Esme Testnet Sep 2, 2022
@sdbondi sdbondi self-assigned this Sep 2, 2022
@SWvheerden SWvheerden mentioned this issue Sep 2, 2022
Closed
@sdbondi sdbondi mentioned this issue Sep 2, 2022
Merged
stringhandler pushed a commit that referenced this issue Sep 6, 2022
@sdbondi
fix(wallet): detect base node change during long-running protocols (#…
2a2a8b6 
…4610)

Description
---

Interrupt txo_validation_protocol and txo_validation_task if base node is changed

Motivation and Context
---
These long-running tasks continue to run using the same base node even if it has changed. This PR checks for base node changes and interrupts the tasks at the correct points.

Other tasks may also need to be interrupted in a similar way.

Ref #4599 - this may fix this issue, but more info is needed to confirm

How Has This Been Tested?
---
Manually, changing the base node and checking that the tasks end.
@sdbondi sdbondi removed their assignment Sep 9, 2022
@sdbondi sdbondi moved this from In Progress to Bugs in Tari Esme Testnet Sep 9, 2022
@sdbondi
Copy link
Member

sdbondi commented Sep 9, 2022

@SWvheerden Please confirm if this still happens or if #4610 resolves it

@SWvheerden
Copy link
Collaborator Author

I think we can close this, I cant seem to validate that the wallet uses any other node if it has a node set, even if the base node is closed

Repository owner moved this from Bugs to Done in Tari Esme Testnet Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdbondi @SWvheerden