Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all sql migrations #4356

Closed
SWvheerden opened this issue Jul 28, 2022 · 1 comment
Closed

Consolidate all sql migrations #4356

SWvheerden opened this issue Jul 28, 2022 · 1 comment
Assignees
@jorgeantonio21

Comments

@SWvheerden
Copy link
Collaborator

The wallet has a lot of leftover migrations that are not used anymore.
All of the migrations can be consolidated into single up/down files for each used table with the correct fields.

The longer we leave this the more messier this becomes, ideally we want to only have a single set for when we do mainnet.
@SWvheerden SWvheerden assigned SWvheerden and unassigned SWvheerden Aug 3, 2022
@SWvheerden SWvheerden mentioned this issue Aug 4, 2022
Merged
@jorgeantonio21 jorgeantonio21 self-assigned this Aug 5, 2022
@jorgeantonio21 jorgeantonio21 mentioned this issue Aug 8, 2022
Merged
aviator-app bot pushed a commit that referenced this issue Aug 9, 2022
@jorgeantonio21
fix: consolidate sql migrations (see issue #4356) (#4415)
91cd76f 
Description
--- 
Currenlty, wallet sql migrations have not been consolidated. This implies, that there exists many duplicate queries that are not anymore necessary. The current PR attempts to simplify the process and thus add logic to create the necessary sql tables once.

Motivation and Context
--- 
Tackle issue #4356.

How Has This Been Tested?
--- 
Own verification.
@SWvheerden
Copy link
Collaborator Author

fixed in: #4415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWvheerden @jorgeantonio21