Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message challenge should use hashing API #4333

Closed
AaronFeickert opened this issue Jul 21, 2022 · 0 comments
Closed

Message challenge should use hashing API #4333

AaronFeickert opened this issue Jul 21, 2022 · 0 comments
Assignees
@jorgeantonio21
Labels
A-security Area - Security related

Comments

@AaronFeickert
Copy link
Collaborator

Message challenges should use the new hashing API.

Additionally, the nomenclature for this is confusing. First, the hash output is used as the input message for the message "origin MAC", which is actually a signature. Additionally, it is not really a challenge, but simply a binding representation of certain message data and metadata. It may be useful to rename this in a way that makes its intent and design more obvious.
This was referenced Jul 22, 2022
Closed
Merged
aviator-app bot pushed a commit that referenced this issue Jul 28, 2022
@jorgeantonio21
fix: address points in issue #4138 and companions (#4336)
2ca0672 
Description
--- Fix issues #4138, #4333 and #4170.

Motivation and Context
--- Add domain separation and cipher authentication for out bound messaging

How Has This Been Tested?
--- Unit tests.
@hansieodendaal hansieodendaal added the A-security Area - Security related label Aug 15, 2022
@hansieodendaal hansieodendaal moved this to Backlog in Tari Esme Testnet Aug 15, 2022
@hansieodendaal hansieodendaal moved this from Backlog to Done in Tari Esme Testnet Aug 15, 2022
@jorgeantonio21 jorgeantonio21 self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
A-security Area - Security related
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jorgeantonio21 @hansieodendaal @AaronFeickert