Reduce universe spam logs

tari-project · Sep 9, 2024 · f921ea3 · f921ea3
1 parent 825ca06
commit f921ea3
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 17 deletions.
diff --git a/applications/minotari_console_wallet/log4rs_sample.yml b/applications/minotari_console_wallet/log4rs_sample.yml
@@ -129,7 +129,7 @@ loggers:
     additive: false
   # network
   comms:
-    level: info
+    level: debug
     appenders:
       - network
     additive: false
@@ -144,7 +144,7 @@ loggers:
       - network
     additive: false
   p2p:
-    level: info
+    level: debug
     appenders:
       - network
   # Route log events sent to the "mio" logger to the "other" appender

diff --git a/base_layer/core/src/base_node/comms_interface/inbound_handlers.rs b/base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
@@ -119,7 +119,7 @@ where B: BlockchainBackend + 'static
     /// Handle inbound node comms requests from remote nodes and local services.
     #[allow(clippy::too_many_lines)]
     pub async fn handle_request(&self, request: NodeCommsRequest) -> Result<NodeCommsResponse, CommsInterfaceError> {
-        debug!(target: LOG_TARGET, "Handling remote request {}", request);
+        trace!(target: LOG_TARGET, "Handling remote request {}", request);
         match request {
             NodeCommsRequest::GetChainMetadata => Ok(NodeCommsResponse::ChainMetadata(
                 self.blockchain_db.get_chain_metadata().await?,

diff --git a/base_layer/core/src/mempool/service/inbound_handlers.rs b/base_layer/core/src/mempool/service/inbound_handlers.rs
@@ -60,7 +60,7 @@ impl MempoolInboundHandlers {
 
     /// Handle inbound Mempool service requests from remote nodes and local services.
     pub async fn handle_request(&mut self, request: MempoolRequest) -> Result<MempoolResponse, MempoolServiceError> {
-        debug!(target: LOG_TARGET, "Handling remote request: {}", request);
+        trace!(target: LOG_TARGET, "Handling remote request: {}", request);
         use MempoolRequest::{GetFeePerGramStats, GetState, GetStats, GetTxStateByExcessSig, SubmitTransaction};
         match request {
             GetStats => Ok(MempoolResponse::Stats(self.mempool.stats().await?)),

diff --git a/base_layer/p2p/src/services/liveness/service.rs b/base_layer/p2p/src/services/liveness/service.rs
@@ -323,7 +323,7 @@ where
             .collect::<Vec<_>>();
 
         if selected_peers.is_empty() {
-            info!(
+            debug!(
                 target: LOG_TARGET,
                 "Cannot broadcast pings because there are no broadcast peers available"
             )

diff --git a/base_layer/wallet/src/base_node_service/monitor.rs b/base_layer/wallet/src/base_node_service/monitor.rs
@@ -187,7 +187,7 @@ where
                 })
                 .await;
 
-            debug!(
+            trace!(
                 target: LOG_TARGET,
                 "Base node {} Tip: {} ({}) Latency: {} ms",
                 base_node_id,

diff --git a/base_layer/wallet/src/transaction_service/tasks/check_faux_transaction_status.rs b/base_layer/wallet/src/transaction_service/tasks/check_faux_transaction_status.rs
@@ -146,17 +146,18 @@ pub async fn check_detected_transactions<TBackend: 'static + TransactionBackend>
         let must_be_confirmed =
             tip_height.saturating_sub(mined_height) >= TransactionServiceConfig::default().num_confirmations_required;
         let num_confirmations = tip_height.saturating_sub(mined_height);
-        debug!(
-            target: LOG_TARGET,
+
+        let log_msg = format!(
             "Updating faux transaction: TxId({}), mined_height({}), must_be_confirmed({}), num_confirmations({}), \
              output_status({}), is_valid({})",
-            tx.tx_id,
-            mined_height,
-            must_be_confirmed,
-            num_confirmations,
-            output_status,
-            is_valid,
+            tx.tx_id, mined_height, must_be_confirmed, num_confirmations, output_status, is_valid
         );
+        if num_confirmations <= 5 {
+            debug!(target: LOG_TARGET, "{}", log_msg);
+        } else {
+            trace!(target: LOG_TARGET, "{}", log_msg);
+        }
+
         let result = db.set_transaction_mined_height(
             tx.tx_id,
             mined_height,

diff --git a/comms/core/src/protocol/rpc/server/mod.rs b/comms/core/src/protocol/rpc/server/mod.rs
@@ -589,7 +589,7 @@ where
                         return Err(err);
                     }
                     let elapsed = start.elapsed();
-                    debug!(
+                    trace!(
                         target: LOG_TARGET,
                         "({}) RPC request completed in {:.0?}{}",
                         self.logging_context_string,
@@ -671,7 +671,7 @@ where
             return Ok(());
         }
 
-        debug!(
+        trace!(
             target: LOG_TARGET,
             "({}) Request: {}, Method: {}",
             self.logging_context_string,

diff --git a/comms/dht/src/connectivity/mod.rs b/comms/dht/src/connectivity/mod.rs
@@ -374,7 +374,7 @@ impl DhtConnectivity {
             .await?;
 
         if new_neighbours.is_empty() {
-            info!(
+            debug!(
                 target: LOG_TARGET,
                 "Unable to refresh neighbouring peer pool because there are insufficient known/online peers",
             );
-Original file line number
+Diff line change
@@ Expand Up / @@ -187,7 +187,7 @@ where @@
                     })
                     .await;
-                debug!(
+                trace!(
                     target: LOG_TARGET,
                     "Base node {} Tip: {} ({}) Latency: {} ms",
                     base_node_id,
@@ Expand Down @@