fix(dht/connectivity): only remove connection handles on connect, not…

… right after refreshing neighbour pool
tari-project · Sep 2, 2022 · f4648dd · f4648dd
1 parent bf9d2e8
commit f4648dd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/applications/tari_base_node/src/commands/command/list_connections.rs b/applications/tari_base_node/src/commands/command/list_connections.rs
@@ -88,7 +88,8 @@ impl CommandContext {
                 format!(
                     "{}hnd: {}, ss: {}, rpc: {}",
                     chain_height.map(|s| format!("{}, ", s)).unwrap_or_default(),
-                    conn.handle_count(),
+                    // Exclude the handle held by list-connections
+                    conn.handle_count().saturating_sub(1),
                     conn.substream_count(),
                     rpc_sessions
                 ),

diff --git a/comms/dht/src/connectivity/mod.rs b/comms/dht/src/connectivity/mod.rs
@@ -406,11 +406,6 @@ impl DhtConnectivity {
             self.insert_neighbour(peer);
         });
 
-        // Drop any connection handles that removed from the neighbour pool
-        difference.iter().for_each(|peer| {
-            self.remove_connection_handle(peer);
-        });
-
         if !new_neighbours.is_empty() {
             self.connectivity.request_many_dials(new_neighbours).await?;
         }