test: reduce cucumber ci to critical only (#3566)

Hopefully by reducing this CI step to critical only, we'll have more green ticks for the check and will have less to maintain regularly. 

Ideally we would want to run all of the tests, but because some of the non-critical ones fail in a flaky manner, devs have started ignoring this step and making it required takes too long.

.circleci/config.yml

@@ -129,7 +129,7 @@ commands:
       - run:
           name: Run cucumber scenarios
           no_output_timeout: 20m
-          command: cd integration_tests && mkdir -p cucumber_output && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken and not @wallet-ffi" --format json:cucumber_output/tests.cucumber --exit --retry 3 --retry-tag-filter "@flaky and not @broken"
+          command: cd integration_tests && mkdir -p cucumber_output && node_modules/.bin/cucumber-js --profile "ci" --tags "@critical and not @long-running and not @broken and not @wallet-ffi" --format json:cucumber_output/tests.cucumber --exit --retry 3 --retry-tag-filter "@flaky and not @broken"
       - run:
           name: Generate report
           command: cd integration_tests && node ./generate_report.js

applications/tari_base_node/src/main.rs

@@ -26,6 +26,7 @@
 #![deny(unused_must_use)]
 #![deny(unreachable_patterns)]
 #![deny(unknown_lints)]
+#![deny(clippy::needless_borrow)]
 
 /// ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⣶⣿⣿⣿⣿⣶⣦⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
 /// ⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣤⣾⣿⡿⠋⠀⠀⠀⠀⠉⠛⠿⣿⣿⣶⣤⣀⠀⠀⠀⠀⠀⠀⢰⣿⣾⣾⣾⣾⣾⣾⣾⣾⣾⣿⠀⠀⠀⣾⣾⣾⡀⠀⠀⠀⠀⢰⣾⣾⣾⣾⣿⣶⣶⡀⠀⠀⠀⢸⣾⣿⠀⠀⠀⠀⠀⠀⠀⠀⠀

applications/tari_console_wallet/src/main.rs

@@ -5,6 +5,7 @@
 #![deny(unused_must_use)]
 #![deny(unreachable_patterns)]
 #![deny(unknown_lints)]
+#![deny(clippy::redundant_clone)]
 #![recursion_limit = "1024"]
 use crate::{recovery::get_seed_from_seed_words, wallet_modes::WalletModeConfig};
 use init::{

base_layer/core/src/base_node/state_machine_service/states/listening.rs

@@ -210,7 +210,7 @@ impl Listening {
 
                     // If we have configured sync peers, they are already filtered at this point
                     let sync_peers = if configured_sync_peers.is_empty() {
-                        select_sync_peers(&best_metadata, &peer_metadata_list)
+                        select_sync_peers(best_metadata, &peer_metadata_list)
                     } else {
                         peer_metadata_list
                     };

base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs

@@ -101,7 +101,7 @@ where TBackend: OutputManagerBackend + 'static
                     let script_key = PrivateKey::random(&mut OsRng);
                     UnblindedOutput::new(
                         output.committed_value,
-                        output.blinding_factor.clone(),
+                        output.blinding_factor,
                         features,
                         script,
                         inputs!(PublicKey::from_secret_key(&script_key)),