-
Notifications
You must be signed in to change notification settings - Fork 219
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: make sure duplication check happens first in mempool (#4627)
Description --- Changes the order of validation in mempool to check the excess signature before checking the inputs. Motivation and Context --- When receiving old transactions, if we check the inputs first, the tx will fail on input validation, and we flag this as a transaction that double spends some input. This is incorrect as it's a rebroadcast of an old already mined transaction. So we check the kernel_excess signature first, and if this is already contained in the blockchain, we just print out a debug message saying we received an old already mined kernel.
- Loading branch information
1 parent
058f492
commit 23e4894
Showing
3 changed files
with
6 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters