Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc)!: remove chunking #1044

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jun 14, 2024

Description

  • remove chunking from RPC protocol

Motivation and Context

Chunking does not add any benefit especially when not using tor.
Porting over changes from L1: tari-project/tari#6345

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Should work as before

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

BREAKING CHANGE: Any responses which previously triggered chunking (>= 256kb) would not be readable by clients using this PR

Copy link

Test Results (CI)

536 tests   - 5   536 ✅  - 5   1h 47m 51s ⏱️ +30s
 63 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 107855b. ± Comparison against base commit ad490ae.

This pull request removes 5 tests.
tari_rpc_framework ‑ server::chunking::test::it_emits_a_single_message
tari_rpc_framework ‑ server::chunking::test::it_emits_a_zero_size_message
tari_rpc_framework ‑ server::chunking::test::it_emits_an_expected_number_of_chunks
tari_rpc_framework ‑ server::chunking::test::it_emits_one_message_below_threshold
tari_rpc_framework ‑ server::chunking::test::it_sets_the_more_flag_except_last

Copy link
Collaborator

@mrnaveira mrnaveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@sdbondi sdbondi added this pull request to the merge queue Jun 14, 2024
Merged via the queue into tari-project:development with commit 9a484a7 Jun 14, 2024
11 checks passed
@sdbondi sdbondi deleted the rpc-remove-chunking branch June 14, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants