Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove unneeded pub uses #94

Merged
merged 10 commits into from
Jul 4, 2022
Merged

fix!: remove unneeded pub uses #94

merged 10 commits into from
Jul 4, 2022

Conversation

stringhandler
Copy link
Contributor

@stringhandler stringhandler commented Apr 8, 2022 •
edited
Loading

There are multiple minor fixes in this PR, but some are potentially breaking.

  • Add a license file
  • Add license header to files that are missing it
  • Add a CI step to check that files have a license. This now matches other projects in tari-project
  • Remove avx2 and simd features, replacing them with simd_backend and u64_backend features, so that they match the features in dalek_curve25519
  • Remove u64_backend when using the simd_backend feature
  • Replace rusttoolchain with rusttoolchain.toml
  • Make default toolchain stable
  • Enable the 'missing_docs' lint and added many missing docs
  • Added CI step to check that docs can be run successfully

Closes some of #73

BREAKING CHANGE: Blake256 no longer re-exposed under the common mod and must be imported as hash::blake2::Blake256
BREAKING CHANGE: avx2 and simd features have been removed. Use simd_backend instead
BREAKING CHANGE: macros mod is now private
BREAKING CHANGE: Various constants have been made private
BREAKING CHANGE: DalekRangeProofService moved from ristretto::dalek_range_proof to ristretto
BREAKING CHANGE: ristretto_com_sig and ristretto_sig mods have been made private. The structs and methods inside were already re-exposed under ristretto

@stringhandler stringhandler force-pushed the mb-fix-docs branch 2 times, most recently from db8b172 to 6a61cdd Compare April 8, 2022 11:49
sdbondi
sdbondi previously approved these changes Apr 8, 2022
View reviewed changes
src/ristretto/constants.rs Outdated Show resolved Hide resolved
@hansieodendaal
Copy link
Contributor

Definitely an improvement

CjS77
CjS77 previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - conflicts need resolving

@stringhandler
Merge branch 'main' into mb-fix-docs
0075809 
# Conflicts:
#	Cargo.toml
#	benches/range_proof.rs
#	src/lib.rs
#	src/range_proof.rs
#	src/ristretto/pedersen/commitment_factory.rs
#	src/wasm/range_proofs.rs
@CjS77 CjS77 merged commit b81f1bb into tari-project:main Jul 4, 2022
@CjS77 CjS77 mentioned this pull request Jul 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjS77 CjS77 CjS77 approved these changes

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stringhandler @hansieodendaal @sdbondi @CjS77