Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: protect public key zeroization against updates #235

Merged
merged 1 commit into from
Oct 13, 2024
Merged

chore: protect public key zeroization against updates #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ristretto/ristretto_keys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,13 @@ impl RistrettoPublicKey {
impl Zeroize for RistrettoPublicKey {
/// Zeroizes both the point and (if it exists) the compressed point
fn zeroize(&mut self) {
self.point.zeroize();
// This destructuring is to trigger a compiler error on future updates!
let Self { point, compressed } = self;

point.zeroize();

// Need to empty the cell
if let Some(mut compressed) = self.compressed.take() {
if let Some(mut compressed) = compressed.take() {
compressed.zeroize();
}
}
Expand Down